Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/2595#issuecomment-57862630
  
    I got mixed results from testing:
    On EC2 cluster with 16 nodes, on both synthetic data and the MNIST8m data, 
I found this PR sped things up for large (deep) trees.  For smaller trees 
(depth 5 or so), it can actually slow things down.  But it is probably a good 
change if it optimizes for larger trees.
    
    E.g., on MNIST8m, with 1 depth-9 tree, runtimes were:
    before: 337.450041744
    this PR: 74.306151717


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to