Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/18950#discussion_r134498890 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -724,6 +777,62 @@ private[spark] class ExecutorAllocationManager( } /** + * Calculate the maximum no. of concurrent tasks that can run currently. + */ + def getMaxConTasks(): Int = { + val stagesByJobGroup = stageIdToNumTasks.groupBy(x => jobIdToJobGroup(stageIdToJobId(x._1))) + + def getMaxConTasks(maxConTasks: Int, + stagesByJobGroupItr: Iterator[(String, mutable.HashMap[Int, Int])]): Int = { --- End diff -- style nit: with multi-line method definitions, each param goes on its own line, double-indented: ```scala def getMaxConTasks( maxConTasks: Int, stagesByJobGroupItr: Iterator[(String, mutable.HashMap[Int, Int])]): Int = { ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org