Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/18962#discussion_r134497719 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -217,7 +217,9 @@ object SparkSubmit extends CommandLineUtils { * (4) the main class for the child * Exposed for testing. */ - private[deploy] def prepareSubmitEnvironment(args: SparkSubmitArguments) + private[deploy] def prepareSubmitEnvironment( + args: SparkSubmitArguments, + conf: Option[HadoopConfiguration] = None) --- End diff -- looks like conf parameter is only used for testing? Perhaps add a comment about it in the description.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org