Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18962#discussion_r134932043
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -330,19 +332,21 @@ object SparkSubmit extends CommandLineUtils {
args.archives = Option(args.archives).map(resolveGlobPaths(_,
hadoopConf)).orNull
// In client mode, download remote files.
+ var localPrimaryResource: String = null
+ var localJars: String = null
+ var localPyFiles: String = null
--- End diff --
@tgravescs , if we also download files/archives to local path, then how do
we leverage them, since we don't expose the path to the user, even with
previous code downloaded files seems never can be used for driver. So for the
semantic completeness, we still need to change some codes to support this
feature as what @vanzin mentioned.
I agree with you current state of the code is confused for user (some are
downloaded which other are not). I think we could fix it in the following PR,
what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
