Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18837#discussion_r135031225
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -510,12 +510,20 @@ trait MesosSchedulerUtils extends Logging {
}
def mesosToTaskState(state: MesosTaskState): TaskState.TaskState = state
match {
- case MesosTaskState.TASK_STAGING | MesosTaskState.TASK_STARTING =>
TaskState.LAUNCHING
- case MesosTaskState.TASK_RUNNING | MesosTaskState.TASK_KILLING =>
TaskState.RUNNING
+ case MesosTaskState.TASK_STAGING |
+ MesosTaskState.TASK_STARTING => TaskState.LAUNCHING
+ case MesosTaskState.TASK_RUNNING |
+ MesosTaskState.TASK_KILLING => TaskState.RUNNING
case MesosTaskState.TASK_FINISHED => TaskState.FINISHED
- case MesosTaskState.TASK_FAILED => TaskState.FAILED
+ case MesosTaskState.TASK_FAILED |
+ MesosTaskState.TASK_GONE |
+ MesosTaskState.TASK_GONE_BY_OPERATOR => TaskState.FAILED
--- End diff --
Just so my thinking's clear, this still doesn't require the Mesos cluster
to be 1.2+, because the wire protocol is still the same? there won't be older
Mesos client libs lying around that would cause this to fail at runtime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
