Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18837#discussion_r135353586
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
 ---
    @@ -58,13 +58,40 @@ package object config {
     
       private[spark] val DRIVER_LABELS =
         ConfigBuilder("spark.mesos.driver.labels")
    -      .doc("Mesos labels to add to the driver.  Labels are free-form 
key-value pairs.  Key-value " +
    +      .doc("Mesos labels to add to the driver.  Labels are free-form 
key-value pairs. Key-value " +
             "pairs should be separated by a colon, and commas used to list 
more than one." +
             "Ex. key:value,key2:value2")
           .stringConf
           .createOptional
     
    -  private[spark] val DRIVER_FAILOVER_TIMEOUT =
    +  private[spark] val SECRET_NAME =
    +    ConfigBuilder("spark.mesos.driver.secret.name")
    +      .doc("A comma-separated list of secret references. Consult the Mesos 
Secret protobuf for " +
    +        "more information.")
    +      .stringConf
    +      .createOptional
    +
    +  private[spark] val SECRET_VALUE =
    +    ConfigBuilder("spark.mesos.driver.secret.value")
    +      .doc("A comma-separated list of secret values.")
    +      .stringConf
    +      .createOptional
    +
    +  private[spark] val SECRET_ENVKEY =
    +    ConfigBuilder("spark.mesos.driver.secret.envkey")
    +      .doc("A comma-separated list of the environment variables to contain 
the secrets." +
    --- End diff --
    
    Ditto.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to