Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18966#discussion_r135164815
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BenchmarkWideTable.scala
 ---
    @@ -42,12 +42,16 @@ class BenchmarkWideTable extends BenchmarkBase {
         /**
          * Here are some numbers with different split threshold:
          *
    -     *  Split threshold      methods       Rate(M/s)   Per Row(ns)
    -     *  10                   400           0.4         2279
    -     *  100                  200           0.6         1554
    -     *  1k                   37            0.9         1116
    -     *  8k                   5             0.5         2025
    -     *  64k                  1             0.0        21649
    +     *  Split threshold      Rate(M/s)   Per Row(ns)
    +     *  10                   0.5         2131.3
    +     *  20                   0.5         2073.7
    +     *  40                   0.5         2085.2
    +     *  64                   0.5         2012.2
    +     *  80                   0.5         2112.2
    +     *  100                  0.5         1984.0
    +     *  128                  0.5         2097.9
    +     *  256                  0.5         2038.9
    +     *  1024                 0.5         2045.2
    --- End diff --
    
    @gatorsmile Sorry, I updated the result. This threshold impacts this test 
case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to