Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r136240918 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -1058,7 +1068,17 @@ object CodeGenerator extends Logging { try { evaluator.cook("generated.java", code.body) - recordCompilationStats(evaluator) + val methodsToByteCodeSize = updateAndGetCompilationStats(evaluator) + methodsToByteCodeSize.foreach { case (name, byteCodeSize) => + if (byteCodeSize > hugeMethodLimit) { + val clazzName = evaluator.getClazz.getSimpleName + val methodName = name.replace("$", "") + throw new IllegalArgumentException( + s"the size of $clazzName.$methodName is $byteCodeSize and this value goes over " + + s"the HugeMethodLimit $hugeMethodLimit (JVM doesn't compile methods " + + "larger than this limit)") --- End diff -- ok
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org