Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19083#discussion_r136240836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1001,6 +1001,16 @@ abstract class CodeGenerator[InType <: AnyRef,
OutType <: AnyRef] extends Loggin
}
object CodeGenerator extends Logging {
+
+ // This is the value of `HugeMethodLimit` in JVM settings. Since we
can't get this value on
+ // runtime and this is fixed in released JVMs, we hard-code this values
here:
+ //
+ // $ java -XX:+UnlockDiagnosticVMOptions -XX:HugeMethodLimit=99999
+ // Error: VM option 'HugeMethodLimit' is develop and is available only
in debug version of VM.
+ // Error: Could not create the Java Virtual Machine.
+ // Error: A fatal exception has occurred. Program will exit.
+ private val hugeMethodLimit = 8000
--- End diff --
I see. I feel detecting specific JVM implementations might go too far for
this purpose. yea, one of options is to add an internal option for this. WDYT?
@rednaxelafx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
