Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19124#discussion_r137170635
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -848,4 +851,19 @@ object DDLUtils {
           }
         }
       }
    +
    +  private[sql] def checkFieldNames(table: CatalogTable): Unit = {
    +    val serde = table.storage.serde
    +    if (serde == HiveSerDe.sourceToSerDe("orc").get.serde) {
    --- End diff --
    
    This way is not right. Let use your previous way with a foreach loop
    ```
        table.provider.foreach {
          _.toLowerCase(Locale.ROOT) match {
            case "hive" =>
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to