Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19124#discussion_r137170969
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -848,4 +851,19 @@ object DDLUtils {
}
}
}
+
+ private[sql] def checkFieldNames(table: CatalogTable): Unit = {
+ val serde = table.storage.serde
+ if (serde == HiveSerDe.sourceToSerDe("orc").get.serde) {
+ OrcFileFormat.checkFieldNames(table.dataSchema)
+ } else if (serde == HiveSerDe.sourceToSerDe("parquet").get.serde) {
--- End diff --
We could have different Parquet serde. For example,
`parquet.hive.serde.ParquetHiveSerDe` and
`org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe`. How about ORC?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
