Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19124#discussion_r137178908
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -848,4 +851,19 @@ object DDLUtils {
           }
         }
       }
    +
    +  private[sql] def checkFieldNames(table: CatalogTable): Unit = {
    +    val serde = table.storage.serde
    +    if (serde == HiveSerDe.sourceToSerDe("orc").get.serde) {
    +      OrcFileFormat.checkFieldNames(table.dataSchema)
    +    } else if (serde == HiveSerDe.sourceToSerDe("parquet").get.serde) {
    --- End diff --
    
    AFAIK, it's only `org.apache.hadoop.hive.ql.io.orc.OrcSerde`.  I checked 
again whether Apache ORC 1.4.0 have some renamed one under `hive-storage` API 
or not. But, it doesn't have it.
    
    For parquet, I'll handle that too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to