Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19177#discussion_r137943462
  
    --- Diff: dev/sparktestsupport/modules.py ---
    @@ -459,6 +459,10 @@ def __hash__(self):
         dependencies=[hive, mllib],
         source_file_regexes=[
             "R/",
    +        "sql/core/src/main/scala/org/apache/spark/sql/api/r/",
    +        "core/src/main/scala/org/apache/spark/api/r/",
    +        "mllib/src/main/scala/org/apache/spark/ml/r/",
    +        
"core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala",
    --- End diff --
    
    do you mean `dependencies=[hive, mllib]`?
    possibly - I'm not seeing `core/src` perhaps that's implicit or is it the 
default set.. I thought it would be better to be explicit in case the modules 
change


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to