Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19177#discussion_r137943782
--- Diff: dev/sparktestsupport/modules.py ---
@@ -459,6 +459,10 @@ def __hash__(self):
dependencies=[hive, mllib],
source_file_regexes=[
"R/",
+ "sql/core/src/main/scala/org/apache/spark/sql/api/r/",
+ "core/src/main/scala/org/apache/spark/api/r/",
+ "mllib/src/main/scala/org/apache/spark/ml/r/",
+
"core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala",
--- End diff --
Yes, it is. If my understanding is correct, both dependencies include
`sparkr` and if there is any file not matching with it, it sets `root` that
runs everything.
How about fixing it later when this one causes actual problems? I gets the
point of explicitly setting them but less sure because it adds lines but does
not look fixing an (actual or potential) issue ..
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
