Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19130#discussion_r138694708
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -897,6 +897,80 @@ class SparkSubmitSuite
         sysProps("spark.submit.pyFiles") should (startWith("/"))
       }
     
    +  test("handle remote http(s) resources in yarn mode") {
    --- End diff --
    
    It seems you have 3 different tests in this block (at least), could you 
break them into separate tests?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to