Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19130#discussion_r138980897
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -897,6 +897,76 @@ class SparkSubmitSuite
         sysProps("spark.submit.pyFiles") should (startWith("/"))
       }
     
    +  test("download remote resource if it is not supported by yarn service") {
    +    testRemoteResources(isHttpSchemeBlacklisted = false, supportMockHttpFs 
= false)
    +  }
    +
    +  test("avoid downloading remote resource if it is supported by yarn 
service") {
    +    testRemoteResources(isHttpSchemeBlacklisted = false, supportMockHttpFs 
= true)
    +  }
    +
    +  test("force downloading remote resource if it's scheme is configured") {
    +    testRemoteResources(isHttpSchemeBlacklisted = true, supportMockHttpFs 
= true)
    +  }
    +
    +  private def testRemoteResources(
    +      isHttpSchemeBlacklisted: Boolean, supportMockHttpFs: Boolean): Unit 
= {
    --- End diff --
    
    break multi-line args one per line.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to