Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/17819
  
    @WeichenXu123 According to 
https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.4.4 and 
https://wiki.eclipse.org/Evolving_Java-based_APIs_2#Evolving_API_Classes, I 
think adding an interface to a class doesn't break binary compatibility.
    
    I am not sure the exact reason of implementing setter methods for params in 
concrete estimators/transformers. Maybe it is because some params should be 
immutable in models.
    
    Anyway, I will merge the inputCols stuff into existing `Bucketizer` if you 
prefer this way.
    
    
    
    
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to