Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19160#discussion_r139800662 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -115,6 +115,7 @@ private[spark] class Executor( if (!isLocal) { env.metricsSystem.registerSource(executorSource) env.blockManager.initialize(conf.getAppId) + env.metricsSystem.registerSource(env.blockManager.shuffleMetricsSource) --- End diff -- super nit: can you put the `reigsterSource()` calls next to each other?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org