Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19160#discussion_r140051678
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -248,6 +251,16 @@ private[spark] class BlockManager(
logInfo(s"Initialized BlockManager: $blockManagerId")
}
+ def shuffleMetricsSource: Source = {
+ import BlockManager._
+
+ if (externalShuffleServiceEnabled) {
+ new ShuffleMetricsSource("ExternalShuffle",
shuffleClient.shuffleMetrics())
+ } else {
+ new ShuffleMetricsSource("NettyBlockTransfer",
shuffleClient.shuffleMetrics())
--- End diff --
ok, I guess I haven't seen enough setups to know how users subscribe to
these and whether they'd actually want that distinction. (especially since it
seems like some of the distinction probably shouldn't be there, eg. the
openBlockLatency metric.) But I don't think there is any clear right answer
here, if you think this is the best naming, that is fine with me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
