Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19338#discussion_r140823764
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -838,7 +840,7 @@ private[spark] class TaskSetManager(
if (!isZombie && reason.countTowardsTaskFailures) {
taskSetBlacklistHelperOpt.foreach(_.updateBlacklistForFailedTask(
- info.host, info.executorId, index))
+ info.host, info.executorId, index, Some(failureReason)))
assert (null != failureReason)
--- End diff --
move the `assert (null != failureReason)` first, and to go along with the
other change, drop the `Some` wrapper around `failureReason`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
