Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19338#discussion_r140823560
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetBlacklist.scala ---
@@ -94,7 +96,9 @@ private[scheduler] class TaskSetBlacklist(val conf:
SparkConf, val stageId: Int,
private[scheduler] def updateBlacklistForFailedTask(
host: String,
exec: String,
- index: Int): Unit = {
+ index: Int,
+ failureReason: Option[String] = None): Unit = {
--- End diff --
`failureReason` should always be present in this call, so it shouldn't be
an `Option` as an arg to this method.
(I realize this is a bit of a pain as you have to modify all the call sites
in tests, sorry about that).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
