Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r140832619 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -40,20 +40,29 @@ import org.apache.spark.util.random.XORShiftRandom * to it should be cached by the user. */ @Since("0.8.0") -class KMeans private ( +class KMeans @Since("2.3.0") private ( --- End diff -- If it's a private constructor, it shouldn't have API "Since" annotations. You don't need to preserve it for compatibility.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org