Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19340#discussion_r140832224
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala 
---
    @@ -260,7 +269,8 @@ class KMeans @Since("1.5.0") (
         maxIter -> 20,
         initMode -> MLlibKMeans.K_MEANS_PARALLEL,
         initSteps -> 2,
    -    tol -> 1e-4)
    +    tol -> 1e-4,
    +    distanceMeasure -> DistanceSuite.EUCLIDEAN)
    --- End diff --
    
    "DistanceSuite" sounds like a test case, which you can't use here, but, 
looks like it's an object you added in non-test code. That's confusing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to