Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19324#discussion_r141038175
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
---
@@ -235,10 +228,12 @@ case class BroadcastHashJoinExec(
|${keyEv.code}
|// find matches from HashedRelation
|UnsafeRow $matched = $anyNull ? null:
(UnsafeRow)$relationTerm.getValue(${keyEv.value});
- |if ($matched == null) continue;
- |$checkCondition
- |$numOutput.add(1);
- |${consume(ctx, resultVars)}
+ |if ($matched != null) {
+ | $checkCondition {
--- End diff --
good trick
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
