Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19324#discussion_r141038684 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -201,11 +201,14 @@ case class FilterExec(condition: Expression, child: SparkPlan) ev } + // Note: wrap in "do { } while(false);", so the generated checks can jump out with "continue;" --- End diff -- ah i see, you are trying to avoid generating deeply nested if-else branches.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org