Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19367#discussion_r141365196
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -718,62 +705,69 @@ class ColumnarBatchSuite extends SparkFunSuite {
column.putArray(0, 0, array.length)
assert(ColumnVectorUtils.toPrimitiveJavaArray(column.getArray(0)).asInstanceOf[Array[Int]]
=== array)
- }}
}
test("toArray for primitive types") {
- // (MemoryMode.ON_HEAP :: MemoryMode.OFF_HEAP :: Nil).foreach {
memMode => {
- (MemoryMode.ON_HEAP :: Nil).foreach { memMode => {
+ (MemoryMode.ON_HEAP :: MemoryMode.OFF_HEAP :: Nil).foreach { memMode
=> {
+ // (MemoryMode.ON_HEAP :: Nil).foreach { memMode => {
--- End diff --
Can we remove this line?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
