Github user ala commented on a diff in the pull request:
https://github.com/apache/spark/pull/19367#discussion_r141371354
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -422,17 +420,14 @@ class ColumnarBatchSuite extends SparkFunSuite {
assert(v._1 == Platform.getLong(null, addr + 8 * v._2))
}
}
- }}
}
- test("Float APIs") {
- (MemoryMode.ON_HEAP :: MemoryMode.OFF_HEAP :: Nil).foreach { memMode
=> {
+ testVector("Float Apis", 1024, FloatType, MemoryMode.ON_HEAP,
MemoryMode.OFF_HEAP) {
--- End diff --
I think changing `Apis` to `APIs` would be better than the other way
around.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
