Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r142220283 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params /** @group getParam */ def getMaxSentenceLength: Int = $(maxSentenceLength) + /** + * Number of negative samples to use with CBOW based estimation. + * This parameter is ignored for SkipGram based estimation. + * Default: 15 + * @group param + */ + final val negativeSamples = new IntParam(this, "negativeSamples", "Number of negative samples " + --- End diff -- In relation to #18123 I wonder if it is necessary to have 3 possible values for `solver`? For `skipgram` if we set this param `negativeSamples` to `0` will that give the same effect as normal skipgram?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org