Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r142215925 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -171,20 +210,46 @@ final class Word2Vec @Since("1.4.0") ( @Since("2.0.0") def setMaxSentenceLength(value: Int): this.type = set(maxSentenceLength, value) + /** @group setParam */ + @Since("2.2.0") + val solvers = Set("sg-hs", "cbow-ns") --- End diff -- We typically put these types of variables in the companion objects. I don't think it's necessary to make it public either. Also, it may be a good idea to extract the strings in constants.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org