Github user caneGuy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19399#discussion_r143114423
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -487,8 +487,10 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
       protected def mergeApplicationListing(fileStatus: FileStatus): Unit = {
         val eventsFilter: ReplayEventsFilter = { eventString =>
           eventString.startsWith(APPL_START_EVENT_PREFIX) ||
    -        eventString.startsWith(APPL_END_EVENT_PREFIX) ||
    -        eventString.startsWith(LOG_START_EVENT_PREFIX)
    +      eventString.startsWith(APPL_END_EVENT_PREFIX) ||
    +      eventString.startsWith(LOG_START_EVENT_PREFIX) ||
    +      eventString.startsWith(JOB_START_EVENT_PREFIX) ||
    +      eventString.startsWith(JOB_END_EVENT_PREFIX)
    --- End diff --
    
    Actually i have not do any benchmark test for this modify.But it has been 
tested with our production cluster.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to