Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19399#discussion_r143589815
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -833,10 +850,12 @@ private[history] class AppListingListener(log: 
FileStatus, clock: Clock) extends
         var sparkUser: String = null
         var completed = false
         var appSparkVersion = ""
    +    val jobToStatus = new mutable.HashMap[Int, String]
     
         def toView(): AttemptInfoWrapper = {
           val apiInfo = new v1.ApplicationAttemptInfo(
             attemptId,
    +        applicationStatus.get,
    --- End diff --
    
    Here, the result of applicationStatus is always defined, so no need to 
return `Option[String]`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to