Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19250#discussion_r143242256
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ---
    @@ -1213,6 +1213,71 @@ case class ToUTCTimestamp(left: Expression, right: 
Expression)
     }
     
     /**
    + * This modifies a timestamp to show how the display time changes going 
from one timezone to
    + * another, for the same instant in time.
    + *
    + * We intentionally do not provide an ExpressionDescription as this is not 
meant to be exposed to
    + * users, its only used for internal conversions.
    + */
    +private[spark] case class TimestampTimezoneCorrection(
    --- End diff --
    
    I guess you could use ToUTCTimestamp / FromUTCTimestamp for this, but that 
would be more expensive since you'd be doing the conversion twice for each 
value.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to