Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19250#discussion_r143243228
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ---
    @@ -1015,6 +1020,10 @@ object DateTimeUtils {
         guess
       }
     
    +  def convertTz(ts: SQLTimestamp, fromZone: String, toZone: String): 
SQLTimestamp = {
    +    convertTz(ts, getTimeZone(fromZone), getTimeZone(toZone))
    --- End diff --
    
    I guess caching the value as done by the `FromUTCTimestamp` expression is 
the right way to go?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to