Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18596253
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -40,10 +40,9 @@ case class Aggregator[K, V, C] (
def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]]):
Iterator[(K, C)] =
combineValuesByKey(iter, null)
- def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]],
- context: TaskContext): Iterator[(K, C)] = {
+ def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]], context:
TaskContext): Iterator[(K, C)] = {
--- End diff --
Normally yes, but in Spark we also have a 100 character limit per line, so
if we don't break it down into multiple lines it won't pass the style tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
