Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18565055
--- Diff: core/src/main/scala/org/apache/spark/ui/UIWorkloadGenerator.scala
---
@@ -17,11 +17,11 @@
package org.apache.spark.ui
-import scala.util.Random
-
-import org.apache.spark.{SparkConf, SparkContext}
import org.apache.spark.SparkContext._
import org.apache.spark.scheduler.SchedulingMode
+import org.apache.spark.{SparkConf, SparkContext}
+
+import scala.util.Random
--- End diff --
Spark code base convention is to import `scala` first. I have actually
never seen a project that uses lexicographical sort order globally, but overall
groups imports logically and then sorts. In any event, it's better to follow
standard convention and put `scala` first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
