Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19470#discussion_r144457235
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
    @@ -138,8 +138,7 @@ class OrcFileFormat extends FileFormat with 
DataSourceRegister with Serializable
           if (maybePhysicalSchema.isEmpty) {
    --- End diff --
    
    nit
    ```
    val isEmptyFile = OrcFileOperator.readSchema(Seq(file.filePath), 
Some(conf)).isEmpty
    if (isEmptyFile) {
      ...
    } else ...
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to