Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19470#discussion_r144457357
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -138,8 +138,7 @@ class OrcFileFormat extends FileFormat with
DataSourceRegister with Serializable
if (maybePhysicalSchema.isEmpty) {
Iterator.empty
} else {
- val physicalSchema = maybePhysicalSchema.get
- OrcRelation.setRequiredColumns(conf, physicalSchema,
requiredSchema)
+ OrcRelation.setRequiredColumns(conf, dataSchema, requiredSchema)
--- End diff --
does it work? seems here we lie to the orc reader about the physical schema.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
