Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19568#discussion_r147471054
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/InnerJoinSuite.scala
 ---
    @@ -228,6 +230,27 @@ class InnerJoinSuite extends SparkPlanTest with 
SharedSQLContext {
         )
       )
     
    +  testInnerJoin(
    --- End diff --
    
    This test fails in 2.1.1 and versions before 
https://github.com/apache/spark/commit/6b6dd682e84d3b03d0b15fbd81a0d16729e521d2.
 I'm not sure how to exercise the code generated by CodegenFallback with that 
fix, but this test is valid for the 2.1.1 branch.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to