Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19568
  
    @rdblue Yes, the current implementation implicitly assumes the rule 
`CollapseCodegenStages ` excludes all the illegal cases. How about adding an 
`assert` to do the check that the condition of `SortMergeJoinExec` does not 
have `CodegenFallback ` expressions? Also write a code comment to explain 
`CollapseCodegenStages ` guarantees the assumption?
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to