Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19208#discussion_r149227049
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
    @@ -108,11 +111,19 @@ abstract class MLWriter extends BaseReadWrite with 
Logging {
       protected def saveImpl(path: String): Unit
     
       /**
    -   * `option()` handles extra options. If subclasses need to support extra 
options, override this
    -   * method.
    +   * Map store extra options for this writer.
    +   */
    +  protected val optionMap: mutable.Map[String, String] = new 
mutable.HashMap[String, String]()
    +
    +  /**
    +   * `option()` handles extra options.
    --- End diff --
    
    "Adds an option to the underlying MLWriter.  See the documentation for the 
specific model's writer for possible options.  The option name (key) is 
case-insensitive."


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to