Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19208#discussion_r149228980
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -101,6 +101,20 @@ class TrainValidationSplit @Since("1.5.0")
(@Since("1.5.0") override val uid: St
@Since("2.3.0")
def setParallelism(value: Int): this.type = set(parallelism, value)
+ /**
+ * Whether to collect submodels when fitting. If set, we can get
submodels from
+ * the returned model.
+ *
+ * Note: If set this param, when you save the returned model, you can
set an option
+ * "persistSubModels" to be "true" before saving, in order to save these
submodels.
+ * You can check documents of
+ * {@link
org.apache.spark.ml.tuning.CrossValidatorModel.CrossValidatorModelWriter}
--- End diff --
I haven't checked through TrainValidationSplit yet, but please do make sure
updates to CrossValidator get applied here (and that the updates are checked
for copy errors like this line). Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
