Github user WeichenXu123 commented on the issue:

    https://github.com/apache/spark/pull/19666
  
    @smurching I guess if iterating over gray code will have higher time 
complexity O(n * 2^n), (Not very sure, maybe there's some high efficient 
algos?) , the recursive traverse in my PR only need O(2^n).
    and , recursive traversing has advantage in "pruning", the pruning 
condition I mentioned above "1 <= combNumber <= numSplits", recursive 
traversing can pruning the total subtree, and save about half the time. Can 
iterating over gray code also do this ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to