Github user facaiy commented on the issue:

    https://github.com/apache/spark/pull/19666
  
    I believe that unordered features will benefit a lot from the idea, however 
I have two questions:
    1. I'm a little confused by 964L in `traverseUnorderedSplits`.  Is it a 
backtracking algorithm?
    ```scala
    dfs(binIndex + 1, combNumber, stats) 
    ```
    2. `traverseUnorderedSplits` succeed in decoupling an abstraction from its 
implementation. Cool! However, I just wonder whether we can write a simpler 
function, say, remove `seqOp`, `finalizer`, `T` and collect all logic together 
in one place?
    
    Anyway, thanks for your good work, @WeichenXu123.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to