Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r150240149
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -31,8 +31,8 @@ public static long nextPowerOf2(long num) {
return (highBit == num) ? num : highBit << 1;
}
- public static int roundNumberOfBytesToNearestWord(int numBytes) {
- int remainder = numBytes & 0x07; // This is equivalent to `numBytes %
8`
+ public static long roundNumberOfBytesToNearestWord(long numBytes) {
--- End diff --
I think we should create a new method instead of changing this method. The
added int cast looks scaring.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
