Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r150381892
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -48,6 +49,15 @@ public long size() {
}
/**
+ * Reset the size of the memory block.
--- End diff --
I think it's a really strange and dangerous interface. Why do we have to
set the size? Does the memory consumer complain when he gets a memory block
larger than he requested?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
