Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19698#discussion_r150631869
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -856,22 +832,24 @@ private[ui] class TaskTableRowData(
val logs: Map[String, String])
private[ui] class TaskDataSource(
- tasks: Seq[TaskUIData],
+ tasks: Seq[TaskData],
hasAccumulators: Boolean,
hasInput: Boolean,
hasOutput: Boolean,
hasShuffleRead: Boolean,
hasShuffleWrite: Boolean,
hasBytesSpilled: Boolean,
- lastUpdateTime: Option[Long],
currentTime: Long,
pageSize: Int,
sortColumn: String,
desc: Boolean,
store: AppStatusStore) extends
PagedDataSource[TaskTableRowData](pageSize) {
import StagePage._
- // Convert TaskUIData to TaskTableRowData which contains the final
contents to show in the table
+ // Keep an internal cache of executor log maps so that long task lists
render faster.
+ private val executors = new HashMap[String, Map[String, String]]()
--- End diff --
nit: rename to something like `executorIdToLogs`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
