Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19698#discussion_r150654983
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -1036,8 +1006,13 @@ private[ui] class TaskDataSource(
           shuffleRead,
           shuffleWrite,
           bytesSpilled,
    -      taskData.errorMessage.getOrElse(""),
    -      logs)
    +      info.errorMessage.getOrElse(""),
    +      executorLogs(info.executorId))
    +  }
    +
    +  private def executorLogs(id: String): Map[String, String] = {
    +    executors.getOrElseUpdate(id,
    +      store.executorSummary(id).map(_.executorLogs).getOrElse(Map.empty))
    --- End diff --
    
    ah right, good point


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to