Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151197868
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,31 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' +
sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ try {
--- End diff --
Some old browser doesn't support this function. so I surround with try
catch.
Feature | Chrome | Edge | Firefox | Internet Explorer | Opera | Safari
-- | -- | -- | -- | -- | -- | --
Basic support | 24 | 12 | 29 | 11 | 15 | 10
computed timeZone | 35 | 14 | 53 | No | 30 | 10
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat/resolvedOptions
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
