Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19802#discussion_r152959040
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -206,6 +207,11 @@ public void onFailure(Throwable e) {
private void processOneWayMessage(OneWayMessage req) {
try {
rpcHandler.receive(reverseClient, req.body().nioByteBuffer());
+ } catch (InvalidClassException ice) {
--- End diff --
The problem is that this won't catch all or even most errors resulting from
version incompatibility. Spark has never supported or contemplated mis-matching
versions internally. I don't think we should try to handle this, because it's
fundamentally piecemeal and hacky.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
