Github user Jiri-Kremser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19802#discussion_r152960380
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -206,6 +207,11 @@ public void onFailure(Throwable e) {
private void processOneWayMessage(OneWayMessage req) {
try {
rpcHandler.receive(reverseClient, req.body().nioByteBuffer());
+ } catch (InvalidClassException ice) {
--- End diff --
Perhaps I should have picked different name for the PR than `Handling
spark-submit and master version mismatch`. It doesn't try to solve the issue in
a complex way that two different version could be able to talk to each other,
all it does is saying the user. Hey, you have probably different version than
spark master. I agree, it's little bit hacky, on the other hand I see no other
option than to catch the `InvalidClassException`, if the version is not part of
the message. Perhaps some initial handshake in which the version is sent would
be cleaner.
What about re-throwing the exception. This way it wouldn't change the
semantics of the code, but the client would be informed. wdyt?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
